Skip to content

Conversation

gjmooney
Copy link
Contributor

@gjmooney gjmooney commented Nov 5, 2024

Continuing @jtpio's work in #7354

Adds HtmlWebpackPlugin to inject cache-busting script tag.

Fixes #7373
Fixes #7221

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Binder 👈 Launch a Binder on branch gjmooney/notebook/webpack_prod

@gjmooney gjmooney marked this pull request as ready for review November 6, 2024 14:07
@jtpio
Copy link
Member

jtpio commented Nov 6, 2024

Thanks @gjmooney for picking this up!

Checking with the assets built by the releaser on CI, the ?v= cache busting parameter now seems to be inlined correctly:

image

While it was not the case until now, for example when testing with notebook 7.2.2:

image

So it looks good, also since it follows what JupyterLab does: jupyterlab/jupyterlab#9776

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 110e728 into jupyter:main Nov 6, 2024
32 checks passed
@jtpio
Copy link
Member

jtpio commented Nov 6, 2024

Cutting a new beta with this change now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nothing shown in the browser Safari when notebook is upgrade to 7.2.0 Blank page if local_names are non trivial

2 participants